Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https in example GitHub Enterprise URL in Javadocs #1521

Merged
merged 1 commit into from Sep 27, 2022

Conversation

AlexLandau
Copy link
Contributor

I just spent a few hours banging my head against some mysterious errors that were resolved by using an https-based URL instead of an http one. I had copied from the Javadocs example URL and replaced the domain name, and did not notice that it started with http:.

Use https: in the example instead, as that is more likely what people want.

Description

In the Javadocs for GitHubBuilder.withEndpoint, edit the example URL for GitHub Enterprise to use https: rather than http:.

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

I just spent a few hours banging my head against some mysterious errors that were resolved by using an https-based URL instead of an http one. I had copied from the Javadocs example URL and replaced the domain name, and did not notice that it started with `http:`.

Use `https:` in the example instead, as that is more likely what people want.
@AlexLandau AlexLandau marked this pull request as ready for review September 16, 2022 23:33
@bitwiseman bitwiseman merged commit 6613c57 into hub4j:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants