Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProjectsV2Item event payload #1502

Merged
merged 1 commit into from Aug 18, 2022
Merged

Conversation

gsmet
Copy link
Contributor

@gsmet gsmet commented Aug 10, 2022

Frankly, this thing is underdocumented and IMHO not very usable but I
suppose it will improve over time.
Someone asked for it in my Quarkus GitHub App project so I thought I
might as well implement it.

@bitwiseman I think you relaxed the rules about documenting the simple getters but I'll add javadoc if required.

Frankly, this thing is underdocumented and IMHO not very usable but I
suppose it will improve over time.
Someone asked for it in my Quarkus GitHub App project so I thought I
might as well implement it.
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1502 (5e26d18) into main (08785e5) will increase coverage by 0.07%.
The diff coverage is 96.29%.

@@             Coverage Diff              @@
##               main    #1502      +/-   ##
============================================
+ Coverage     78.80%   78.88%   +0.07%     
- Complexity     2113     2123      +10     
============================================
  Files           202      204       +2     
  Lines          6427     6454      +27     
  Branches        361      361              
============================================
+ Hits           5065     5091      +26     
- Misses         1152     1153       +1     
  Partials        210      210              
Impacted Files Coverage Δ
...main/java/org/kohsuke/github/GHProjectsV2Item.java 88.88% <88.88%> (ø)
...c/main/java/org/kohsuke/github/GHEventPayload.java 80.00% <100.00%> (+0.23%) ⬆️
...va/org/kohsuke/github/GHProjectsV2ItemChanges.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bitwiseman
Copy link
Member

@gsmet

Frankly, this thing is underdocumented and IMHO not very usable but I suppose it will improve over time.

I suppose you mean the underlying API, not this PR, right?

@gsmet
Copy link
Contributor Author

gsmet commented Aug 14, 2022

Yes. The PR is fine given what’s in the payload. We can’t do much better.

There might be some things that are not covered as I had to experiment to understand what were in the changes. But it should be resilient enough to not break in this case.

@bitwiseman bitwiseman merged commit e5fb0cd into hub4j:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants