Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the boolean 'disabled' in the repository api #1472

Merged
merged 2 commits into from Jun 20, 2022

Conversation

alexanderkjall
Copy link

Description

The repository json blob contains an attribute called disabed, read and expose that value in the java api.

Upstream documentation here: https://docs.github.com/en/rest/repos/repos

Before submitting a PR:

  • [ x ] Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • [ x ] Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on https://docs.github.com/en/rest .
  • [ x ] Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • [ x ] Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • [ x ] Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • [ x ] Fill in the "Description" above with clear summary of the changes. This includes:
    • [ x ] If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • [ x ] Provide links to relevant documentation on https://docs.github.com/en/rest where possible.
  • [ x ] All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • [ x ] Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #1472 (54fb167) into main (4e103a6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1472   +/-   ##
=========================================
  Coverage     78.77%   78.77%           
- Complexity     2100     2101    +1     
=========================================
  Files           201      201           
  Lines          6392     6393    +1     
  Branches        359      359           
=========================================
+ Hits           5035     5036    +1     
  Misses         1149     1149           
  Partials        208      208           
Impacted Files Coverage Δ
src/main/java/org/kohsuke/github/GHRepository.java 68.39% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e103a6...54fb167. Read the comment docs.

@bitwiseman bitwiseman merged commit 7a16c30 into hub4j:main Jun 20, 2022
@alexanderkjall alexanderkjall deleted the expose-disabled-in-api branch June 21, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants