Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for workflow_job event payload #1462

Merged
merged 1 commit into from Jun 20, 2022

Conversation

gsmet
Copy link
Contributor

@gsmet gsmet commented May 30, 2022

Fixes #1331

@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #1462 (e7add93) into main (4e103a6) will decrease coverage by 0.02%.
The diff coverage is 63.63%.

@@             Coverage Diff              @@
##               main    #1462      +/-   ##
============================================
- Coverage     78.77%   78.74%   -0.03%     
- Complexity     2100     2101       +1     
============================================
  Files           201      201              
  Lines          6392     6403      +11     
  Branches        359      361       +2     
============================================
+ Hits           5035     5042       +7     
- Misses         1149     1151       +2     
- Partials        208      210       +2     
Impacted Files Coverage Δ
...c/main/java/org/kohsuke/github/GHEventPayload.java 79.76% <60.00%> (-0.82%) ⬇️
...rc/main/java/org/kohsuke/github/GHWorkflowJob.java 89.65% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e103a6...e7add93. Read the comment docs.

@gsmet
Copy link
Contributor Author

gsmet commented May 30, 2022

What's not tested in GHEventPayload is the IllegalStateException branches. The rest is properly covered.

@gsmet
Copy link
Contributor Author

gsmet commented Jun 10, 2022

@bitwiseman any chance we could get this one in? The loss in coverage is just caused by the edge cases of IllegalStateException.

@bitwiseman bitwiseman merged commit dd4d83b into hub4j:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement workflow job event payload
2 participants