Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use send() to execute requests instead of fetchHttpStatusCode() #1455

Merged
merged 1 commit into from May 15, 2022

Conversation

gsmet
Copy link
Contributor

@gsmet gsmet commented May 12, 2022

Fixes #1380

Note: I had to take a new snapshot for GHWorkflowTest as the dispatch
test was silently failing before (we were using an input that was not
declared in the workflow, I fixed that in the test workflow).

Fixes hub4j#1380

Note: I had to take a new snapshot for GHWorkflowTest as the dispatch
tests was silently failing before (we were using an input that was not
declared in the workflow, I fixed that in the test workflow).
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1455 (329e29d) into main (a8481fc) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1455      +/-   ##
============================================
- Coverage     78.77%   78.76%   -0.02%     
  Complexity     2100     2100              
============================================
  Files           201      201              
  Lines          6390     6390              
  Branches        359      359              
============================================
- Hits           5034     5033       -1     
  Misses         1149     1149              
- Partials        207      208       +1     
Impacted Files Coverage Δ
src/main/java/org/kohsuke/github/Requester.java 100.00% <ø> (ø)
src/main/java/org/kohsuke/github/GHArtifact.java 77.77% <100.00%> (ø)
src/main/java/org/kohsuke/github/GHWorkflow.java 89.28% <100.00%> (ø)
...rc/main/java/org/kohsuke/github/GHWorkflowRun.java 87.87% <100.00%> (ø)
...ava/org/kohsuke/github/GHWorkflowRunsIterable.java 91.66% <0.00%> (-8.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8481fc...329e29d. Read the comment docs.

@gsmet
Copy link
Contributor Author

gsmet commented May 12, 2022

No idea how the code coverage can be lower given the changes I made :).

@bitwiseman bitwiseman merged commit aa363a5 into hub4j:main May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Determining result of Workflow Dispatch
2 participants