Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate site using Java 17 #1434

Merged
merged 9 commits into from Sep 27, 2022
Merged

Generate site using Java 17 #1434

merged 9 commits into from Sep 27, 2022

Conversation

bitwiseman
Copy link
Member

Description

Fixes #1402

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Base: 79.00% // Head: 79.27% // Increases project coverage by +0.26% 🎉

Coverage data is based on head (61fbccf) compared to base (4c6c312).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1434      +/-   ##
============================================
+ Coverage     79.00%   79.27%   +0.26%     
  Complexity     2137     2137              
============================================
  Files           206      206              
  Lines          6479     6562      +83     
  Branches        362      362              
============================================
+ Hits           5119     5202      +83     
  Misses         1148     1148              
  Partials        212      212              
Impacted Files Coverage Δ
.../main/java/org/kohsuke/github/AbstractBuilder.java 77.77% <ø> (ø)
...ain/java/org/kohsuke/github/AbuseLimitHandler.java 78.94% <ø> (ø)
src/main/java/org/kohsuke/github/GHApp.java 100.00% <ø> (ø)
...va/org/kohsuke/github/GHAppCreateTokenBuilder.java 85.71% <ø> (ø)
...ain/java/org/kohsuke/github/GHAppInstallation.java 91.89% <ø> (ø)
...ava/org/kohsuke/github/GHAppInstallationToken.java 83.33% <ø> (ø)
...org/kohsuke/github/GHAppInstallationsIterable.java 100.00% <ø> (ø)
...ava/org/kohsuke/github/GHAppInstallationsPage.java 66.66% <ø> (ø)
src/main/java/org/kohsuke/github/GHArtifact.java 77.77% <ø> (ø)
...n/java/org/kohsuke/github/GHArtifactsIterable.java 91.66% <ø> (ø)
... and 185 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bitwiseman bitwiseman marked this pull request as draft April 21, 2022 04:07
@bitwiseman bitwiseman marked this pull request as ready for review September 27, 2022 06:33
@bitwiseman bitwiseman merged commit 69537d4 into main Sep 27, 2022
@bitwiseman bitwiseman deleted the issue/site-java-17 branch September 27, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 error in javadoc when try to search
2 participants