Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work in rollup #4

Closed
TJKoury opened this issue Aug 3, 2021 · 2 comments
Closed

Does not work in rollup #4

TJKoury opened this issue Aug 3, 2021 · 2 comments

Comments

@TJKoury
Copy link

TJKoury commented Aug 3, 2021

Rollup has issues with the wasm-bindgen implementation, does not recognize methods / properties attached to wasm object.

Recommend recompiling using --target web;

@pimterry
Copy link
Member

pimterry commented Aug 3, 2021

Interesting! Yes, it seems that rollup doesn't support WASM ESM integration, which is required for the bundler target. There's maybe some progress happening there (rollup/rollup#2099) but very slowly.

If you're keen, I'm open to PRs to support this, if you can find a way to do so that's still compatible with the node & webpack builds as well (if the current tests still pass, that should be enough). I'm not sure exactly how the various package.json fields should be set to support all three targets easily.

Super extra bonus points if you can add a separate test to cover rollup too, so we can make sure this works in future.

@pimterry
Copy link
Member

Now fixed by #13 in version v1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants