Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found a possible security concern #705

Open
JamieSlome opened this issue Jan 6, 2022 · 6 comments
Open

Found a possible security concern #705

JamieSlome opened this issue Jan 6, 2022 · 6 comments

Comments

@JamieSlome
Copy link
Contributor

Hey there!

I belong to an open source security research community, and a member (@ranjit-git) has found an issue, but doesn’t know the best way to disclose it.

If not a hassle, might you kindly add a SECURITY.md file with an email, or another contact method? GitHub recommends this best practice to ensure security issues are responsibly disclosed, and it would serve as a simple instruction for security researchers in the future.

Thank you for your consideration, and I look forward to hearing from you!

(cc @huntr-helper)

@tarcieri
Copy link
Member

tarcieri commented Jan 6, 2022

Please email me at bascule@gmail.com to follow up.

A SECURITY.md is a good idea as well.

@JamieSlome
Copy link
Contributor Author

@tarcieri - thanks for the response!

If you prefer, you can view the report directly here:

https://huntr.dev/bounties/2282338f-f8f6-436c-92c7-fab8da8ff3ab/

It is private and only accessible to maintainers with repository write permissions 🤝

@tarcieri
Copy link
Member

tarcieri commented Jan 8, 2022

Can you go ahead and open a public issue for this?

Since it relies on a trusted site redirecting to a potentially malicious site, it doesn't seem particularly exploitable to me.

cc @ranjit-git

@tarcieri
Copy link
Member

tarcieri commented Jan 8, 2022

I also thought we were relying on HTTP::CookieJar's scoping rules... curious if it's actually an upstream bug in that? https://github.com/httprb/http/pull/613/files

Also related: #631

@ixti
Copy link
Member

ixti commented Jan 8, 2022

I'll take a look this weekend.

@tarcieri
Copy link
Member

Whatever behavior might be incorrect here was probably implemented in #613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants