Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP status 1xx responses (Continue) are not supported #667

Open
jrnk opened this issue May 18, 2021 · 2 comments
Open

HTTP status 1xx responses (Continue) are not supported #667

jrnk opened this issue May 18, 2021 · 2 comments
Assignees

Comments

@jrnk
Copy link

jrnk commented May 18, 2021

See issue #593 and #592 , this issue is still present in the 5.0 release

This code should be in the 5.0 release (from the release notes), but it's missing:

See f.e. on_message_complete on that supposedly merged commit

def on_message_complete(_response)

And the one in the 5.0 release: https://github.com/httprb/http/blob/v5.0.0/lib/http/response/parser.rb#L114

@tarcieri
Copy link
Member

@ixti was this reverted?

@ixti
Copy link
Member

ixti commented May 19, 2021

#651 introduced the regression. Will work on this.

@ixti ixti self-assigned this May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants