Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL::SSL::SSLErrors in test suite #627

Open
tarcieri opened this issue Nov 19, 2020 · 0 comments
Open

OpenSSL::SSL::SSLErrors in test suite #627

tarcieri opened this issue Nov 19, 2020 · 0 comments
Milestone

Comments

@tarcieri
Copy link
Member

CI on master is presently broken, with SSL-related tests failing with the following error:

https://travis-ci.org/github/httprb/http/jobs/744656845

#<OpenSSL::SSL::SSLError: SSL_connect returned=1 errno=0 state=error: sslv3 alert unsupported certificate>
@ixti ixti added this to the v5.0.0 milestone Dec 20, 2020
ixti added a commit that referenced this issue Dec 20, 2020
Specs are failing due to some misconfiguration caused by new OpenSSL.
TODO: #627
ixti added a commit that referenced this issue Dec 20, 2020
Specs are failing due to some misconfiguration caused by new OpenSSL.
TODO: #627
ixti added a commit that referenced this issue Dec 28, 2020
* Switch to GitHub Actions

* Use GitHub Actions for CI
* Update Coveralls integration: generate lcov report with SimpleCov and
  send it after the test suite using coveralls GitHub Actions plugin
* Update and cleanup RSpec config
* Cleanup Rakefile
* Remove active_model dependency (certificate_authority was fixed)

PS: GH Actions syntax is ugly.
  Should we switch to Cirlce CI or GitLab CI? XD

Resolves: #633

* Disable SSL related specs

Specs are failing due to some misconfiguration caused by new OpenSSL.
TODO: #627

* Remove windows and macos from test matrix

We were not testing those on Travis-CI, thus to simplify migration I've
deicded to disable those. Once everything is fixed and stabilized we
will add those too.

* Bump min version of CA and rspec

Just to make sure we're using expected ones

* Make stubbed client in spec more predictable

- use stub_const
- consistently normalize URIs

* Add OpenSSL requirement details for jRuby

/cc @tarcieri Probably we should just add dependency on gem itself?

* Revert "Add OpenSSL requirement details for jRuby"

This reverts commit f8dfb38.

* Fix jRuby regression introduced in #632

jRuby is using outdated openssl gem bundled in, which don't have
validate_hostname getter on SSLContext.

* Fix jRuby coverage abilities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants