WSSE token needs to be string not bytes #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `_wsse_username_token` returned bytes, the header would look like ``` UsernameToken Username="username", PasswordDigest="b'Ue8bnW/FAKEWubcqChWs='", Nonce="673552abeefb06a6", Created="2020-09-29T14:42:57Z" ``` And the extra `b'` at the beginning of the password digest would cause authentication to fail.
temoto
added a commit
that referenced
this pull request
Sep 29, 2020
When `_wsse_username_token` returned bytes, the header would look like ``` UsernameToken Username="username", PasswordDigest="b'Ue8bnW/FAKEWubcqChWs='", Nonce="673552abeefb06a6", Created="2020-09-29T14:42:57Z" ``` And the extra `b'` at the beginning of the password digest would cause authentication to fail. #179 Co-Authored-By: Sergey Shepelev <temotor@gmail.com>
temoto
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
Hi and welcome.
Thank you. Sorry turns out WSSE wasn't working for a while.
I'm waiting for tests on CI and will merge this together with regression test on different branch because github won't let me push to yours. So don't pay much attention to PR status, your work is accepted keeping authorship.
|
Merged in 595e248 |
This was referenced Mar 6, 2021
This was referenced Mar 13, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
_wsse_username_tokenreturned bytes, the header would look likeAnd the extra
b'at the beginning of the password digest would cause authentication to fail.