Tests fail with PySocks-1.7.1

[mgorny]

___________________________________________ test_server_not_found_error_is_raised_for_invalid_hostname ____________________________________________
/usr/lib/python3.8/site-packages/socks.py:787: in connect
    super(socksocket, self).connect(proxy_addr)
/usr/lib/python3.8/site-packages/mock/mock.py:1092: in __call__
    return _mock_self._mock_call(*args, **kwargs)
/usr/lib/python3.8/site-packages/mock/mock.py:1149: in _mock_call
    result = effect(*args, **kwargs)
tests/test_proxy.py:21: in _raise_name_not_known_error
    raise socket.gaierror(socket.EAI_NONAME, "Name or service not known")
E   socket.gaierror: [Errno -2] Name or service not known

During handling of the above exception, another exception occurred:
/usr/lib/python3.8/site-packages/httplib2/__init__.py:1557: in _conn_request
    conn.connect()
/usr/lib/python3.8/site-packages/httplib2/__init__.py:1236: in connect
    raise socket_err
/usr/lib/python3.8/site-packages/httplib2/__init__.py:1210: in connect
    self.sock.connect((self.host, self.port) + sa[2:])
/usr/lib/python3.8/site-packages/socks.py:47: in wrapper
    return function(*args, **kwargs)
/usr/lib/python3.8/site-packages/socks.py:800: in connect
    raise ProxyConnectionError(msg, error)
E   socks.ProxyConnectionError: Error connecting to HTTP proxy 255.255.255.255:8001: [Errno -2] Name or service not known

During handling of the above exception, another exception occurred:
tests/test_proxy.py:116: in test_server_not_found_error_is_raised_for_invalid_hostname
    http.request("http://invalid.hostname.foo.bar/", "GET")
/usr/lib/python3.8/site-packages/httplib2/__init__.py:1985: in request
    (response, content) = self._request(
/usr/lib/python3.8/site-packages/httplib2/__init__.py:1650: in _request
    (response, content) = self._conn_request(
/usr/lib/python3.8/site-packages/httplib2/__init__.py:1567: in _conn_request
    e.args[0].errno if isinstance(e.args[0], socket.error) else e.errno
E   IndexError: tuple index out of range
________________________________________________________________ test_socks5_auth _________________________________________________________________
tests/test_proxy.py:174: in test_socks5_auth
    with tests.assert_raises(httplib2.socks.Socks5AuthError):
E   AttributeError: module 'socks' has no attribute 'Socks5AuthError'

[temoto]

Thanks. Do you have to run tests with pysocks available in packages? httplib2 currently vendors this module but defaults to using external package if available. We should switch to just depending on external package #121 but wasn't done yet.

[mgorny]

If you're asking whether this is high priority for us, then no. I've just skipped these two tests for now.

[temoto]

I meant that running tests in isolated virtualenv without pysocks would solve the issue too. Good to know it's not blocking.

[mgorny]

We don't use virtualenv because it doesn't reliably indicate whether the package's actually going to work correctly in the production environment along with other packages. There are many packages that break in presence of others, and it's better to know that before installing them.

[ivanyu]

Would you consider a patch like #202?

[temoto]

@mgorny does it work on new master?

[mgorny]

I've just tried dce3376 and I can still reproduce it.