Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug no_proxy support #132

Open
jfouret opened this issue Feb 21, 2019 · 0 comments
Open

Bug no_proxy support #132

jfouret opened this issue Feb 21, 2019 · 0 comments

Comments

@jfouret
Copy link

jfouret commented Feb 21, 2019

Hi,

if no_proxy is written with blank spaces between comma, it will not be correctly handled.

example :
no_proxy='example1.com, example2.com'

In addition, by looking at the code I am not sure the following will be correctly handled either:
no_proxy='example1.com,*,example2.com'
OK there is no sense of doing that but it has no reason not to work !?

support of IP range (e.g 10.0.0.0/24) might be also good !

maybe the better would the to
-split the content the of no_proxy variable
-iterate over each splitted string
----remove blankspace at the beginning and the end
----check for forbbiden character (report as warning and ignore ?)
----recognize IP address and also IP address range
----append one (or many in case of IP range) to the bypass_hosts attribute of ProxyInfo class
-replace the by_pass_host method by using a unix-style regex (maybe glob library ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants