Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time elapsed #1277

Merged
merged 10 commits into from Jan 23, 2022
Merged

Fix time elapsed #1277

merged 10 commits into from Jan 23, 2022

Conversation

jkbrzt
Copy link
Member

@jkbrzt jkbrzt commented Jan 23, 2022

  • show the actual time elapsed instead of time-to-parse-headers
  • add docs for response meta

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2022

Codecov Report

Merging #1277 (9e44405) into master (4d7d6b6) will decrease coverage by 0.71%.
The diff coverage is 95.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1277      +/-   ##
==========================================
- Coverage   97.28%   96.57%   -0.72%     
==========================================
  Files          67       85      +18     
  Lines        4235     5952    +1717     
==========================================
+ Hits         4120     5748    +1628     
- Misses        115      204      +89     
Impacted Files Coverage Δ
tests/test_binary.py 100.00% <ø> (ø)
httpie/compat.py 31.11% <27.90%> (-68.89%) ⬇️
tests/conftest.py 77.14% <58.33%> (-9.82%) ⬇️
httpie/output/lexers/http.py 59.09% <59.09%> (ø)
tests/test_ssl.py 91.01% <66.66%> (-3.93%) ⬇️
httpie/manager/__main__.py 82.35% <82.35%> (ø)
httpie/output/lexers/metadata.py 82.35% <82.35%> (ø)
httpie/models.py 94.23% <90.00%> (-3.14%) ⬇️
tests/test_uploads.py 97.66% <92.15%> (-2.34%) ⬇️
httpie/manager/core.py 92.85% <92.85%> (ø)
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a03b7a...9e44405. Read the comment docs.

Copy link
Contributor

@isidentical isidentical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are faster than me 😄 (I was planning this on monday). The conditional body download seems a bit weird, considering how output options can change the total elapsed time but I guess there is no easy solution on that front. Maybe we might consider adding a warning in the future (Elapsed Time: 1.2042824 seconds (excluding time spent on the response body)) or using different keys but since it is documented I guess it is not a big deal.

@jkbrzt
Copy link
Member Author

jkbrzt commented Jan 23, 2022

Yeah, the conditional body download, which is otherwise a good thing, makes the metrics less robust. The notice might be a good idea for a future iteration.

@jkbrzt jkbrzt merged commit c815e21 into master Jan 23, 2022
@jkbrzt jkbrzt deleted the jakub/fix-time-elapsed branch January 23, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants