New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for nested JSON syntax #1169
Merged
isidentical
merged 2 commits into
feature/nested-json
from
mickael/oss-72-syntax-for-nested-json
Nov 26, 2021
Merged
Add support for nested JSON syntax #1169
isidentical
merged 2 commits into
feature/nested-json
from
mickael/oss-72-syntax-for-nested-json
Nov 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoboTiG
changed the title
Added key$=value for nested JSON syntax into request data
Added field$=json for nested JSON syntax support into request data
Oct 1, 2021
Codecov Report
@@ Coverage Diff @@
## feature/nested-json #1169 +/- ##
======================================================
Coverage ? 96.72%
======================================================
Files ? 73
Lines ? 4769
Branches ? 0
======================================================
Hits ? 4613
Misses ? 156
Partials ? 0 Continue to review full report at Codecov.
|
jkbrzt
changed the title
Added field$=json for nested JSON syntax support into request data
Add support for nested JSON syntax
Oct 8, 2021
BoboTiG
force-pushed
the
mickael/oss-72-syntax-for-nested-json
branch
4 times, most recently
from
October 22, 2021 08:26
9868e5d
to
066973a
Compare
isidentical
force-pushed
the
mickael/oss-72-syntax-for-nested-json
branch
from
November 26, 2021 13:26
812f685
to
51f1ce5
Compare
Merging this to |
isidentical
added a commit
to isidentical/httpie
that referenced
this pull request
Dec 2, 2021
Co-authored-by: Batuhan Taskaya <isidentical@gmail.com> Co-authored-by: Jakub Roztocil <jakub@roztocil.co>
jkbrzt
added a commit
that referenced
this pull request
Dec 3, 2021
* Add support for nested JSON syntax (#1169) Co-authored-by: Batuhan Taskaya <isidentical@gmail.com> Co-authored-by: Jakub Roztocil <jakub@roztocil.co> * minor improvements * unpack top level lists * Write more docs * doc style changes * fix double quotes Co-authored-by: Mickaël Schoentgen <contact@tiger-222.fr> Co-authored-by: Jakub Roztocil <jakub@roztocil.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
Data fields (
key=value
) and raw JSON fields (key:=value
) now parse thekey
as JSON form.Example:
The new syntax is compatible with other JSON-specific syntax and can be mixed altogether.
Note: it is not doable to simply use the
jarg
module as it would install PyYAML, and we want to keep our requirements light. I also checked other modules like html-json-forms but I prefer to ship our own code for the same reason: no new module to package. At the end, the new code is maintainable enough, and quite small.