[0.23] Error parsing address from Jetty with ipv6

[perok]

Running http4s 0.23.0-RC1 with Jetty and IPv6 crashes with the following:

ERROR org.http4s.servlet.Http4sServlet - Error processing request
java.util.NoSuchElementException: None.get

The issue is that Jetty returns the following addresses:

req.getLocalAddr -> "[0:0:0:0:0:0:0:1]"
req.getRemoteAddr -> "[0:0:0:0:0:0:0:1]"

This crashes the following parsing IpAddress.fromString(req.getRemoteAddr).getin Http4sServlet. Is brackets on the address considered an error on the parsing side or on Jetty's side?

A temporary workaround for us is to force ipv4 with -Djava.net.preferIPv4Stack=true.

[rossabaker]

[hangs head in shame for using .get]

This looks related to jetty/jetty.project#1503. Rather than say Jetty or ip4s is wrong, I'd say http4s is wrong for assuming they agree. I think we should strip brackets before that call.

Arguably, ip4s should handle both, like the Java APIs. But that's up to @mpilquist.

[mpilquist]

No strong opinions. At first glance, I'd say that bracketed v6 is part of the URI RFC, not IPv6, and hence the brackets should be removed prior to calling IpAddress.fromString. But I very well may be missing something and it may be more practical to handle it in ip4s regardless. Let me know what you think.

[rossabaker]

I think this Jetty comment summarizes the grim situation from the specs. Since I used it as a drop-in for the Java libraries, the argument that it should be compatible with the Java libraries seems good to me.

Regardless, I think we should fix it here and not rely on the generosity of ip4s' parser.

[mpilquist]

😱

[rossabaker]

@san-coding I don't think anybody has taken this up, if you're still looking for one.

[san-coding]

@san-coding I don't think anybody has taken this up, if you're still looking for one.

Thanks ross, yes I am looking forward to contribute , I am always refreshing the issues page and looking for issues I can contribute to

[san-coding]

@rossabaker @mpilquist , I have figured out that I have to change this file servlet/src/main/scala/org/http4s/servlet/Http4sServlet.scala , could you help me out on what changes I should make

[san-coding]

@rossabaker @mpilquist , Is this where I should make changes ? Should we call the stripBracketsFromAddr() function before fromString()

http4s/servlet/src/main/scala/org/http4s/servlet/Http4sServlet.scala

Lines 112 to 119 in 453221b

	local = SocketAddress(
	IpAddress.fromString(stripBracketsFromAddr(req.getLocalAddr)).get,
	Port.fromInt(req.getLocalPort).get),
	remote = SocketAddress(
	IpAddress.fromString(stripBracketsFromAddr(req.getRemoteAddr)).get,
	Port.fromInt(req.getRemotePort).get),
	secure = req.isSecure
	)

[rossabaker]

I'm sorry. That stripBracketsFromAddr already fixes this, and it wasn't linked, so I neglected to close it. I'll look for another one.

[san-coding]

I'm sorry. That stripBracketsFromAddr already fixes this, and it wasn't linked, so I neglected to close it. I'll look for another one.

Ohh okay , thanks