Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New AsyncHttp4sServlet builder doesn't have serviceErrorHandler #160

Open
dhinojosa opened this issue Jan 18, 2023 · 1 comment
Open

New AsyncHttp4sServlet builder doesn't have serviceErrorHandler #160

dhinojosa opened this issue Jan 18, 2023 · 1 comment

Comments

@dhinojosa
Copy link
Contributor

AsyncHttp4sServlet from a discussion with Ross seems to be missing serviceErrorHandler. Not sure if it should be included or not, but I added a ticket just in case.

Here is what methods are included currently.

AsyncHttp4sServlet
          .builder(httpApp, dispatcher)
          .withAsyncTimeout(builder.asyncTimeout)
          .withChunkSize(chunkSize)
          .build
@rossabaker
Copy link
Member

I argue it shouldn't: a middleware achieves the same end, and applies to all httpApp (it's just functions!) instead of needing to be maintained on each backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants