Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle when chunked stream ends prematurely #71

Open
rylev opened this issue Mar 16, 2020 · 2 comments
Open

Handle when chunked stream ends prematurely #71

rylev opened this issue Mar 16, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@rylev
Copy link
Collaborator

rylev commented Mar 16, 2020

We should have some sort of logic when the chunked stream ends prematurely. Right now we just end the stream and leave it to later steps to (maybe?) catch this issue: https://github.com/http-rs/async-h1/pull/69/files#r392666474
@rylev rylev added the enhancement New feature or request label Mar 16, 2020
@yoshuawuyts
Copy link
Member

I suspect we have an out of bounds read issue with chunked encoding as well. This might inform what to do about error handling.

@joshtriplett
Copy link
Member

I managed to hit this case with a stream that doesn't end prematurely: #195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshtriplett @rylev @yoshuawuyts