Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make server buffer writes #200

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kyrias
Copy link

@kyrias kyrias commented Dec 30, 2022

Finally got around to looking at this again and realized that I was looking at it from completely the wrong end last time.

Fixes #199.

Fixes http-rs#199.

Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
@jbr
Copy link
Member

jbr commented Dec 30, 2022

Could you add a bit more explanation of the fix? It's been a bit since I've looked at async-h1

@kyrias
Copy link
Author

kyrias commented Dec 30, 2022

@jbr I'm not sure what more to add other than that the fix is to buffer writes to the socket. Why this is necessary should be described in the references issue.

But if you can say what you feel is missing from the explanation I can try to explain it better.


Edit: I also just realized that this should probably also be done to the client side. Didn't even occur to me before since the only place I use it I end up using so rarely I never noticed whether the same thing happened. Guess I can try to do some tests later, but pretty sure the same thing should happen there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server response sending triggers Nagle's algorithm/delayed ACK interaction
2 participants