Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No matching version found for ecstatic@^3.0.0 #521

Closed
Blackbaud-SteveBrush opened this issue May 2, 2019 · 25 comments
Closed

No matching version found for ecstatic@^3.0.0 #521

Blackbaud-SteveBrush opened this issue May 2, 2019 · 25 comments
Labels
high priority Very important bug or security fix

Comments

@Blackbaud-SteveBrush
Copy link

After typing npm install I get the following:

No matching version found for ecstatic@^3.0.0
@Blackbaud-SteveBrush
Copy link
Author

I'm only seeing one version on ecstatic's npmjs.org page; that can't be good:
https://www.npmjs.com/package/ecstatic

@thornjad
Copy link
Member

thornjad commented May 2, 2019

Looks like ecstatic unpublished all but the latest version. However, the latest version has breaking changes which totally breaks right now #520

see: jfhbrook/node-ecstatic#255

@thornjad thornjad added the high priority Very important bug or security fix label May 2, 2019
@Blackbaud-ShaydeNofziger

https://www.npmjs.com/advisories/830

Open Redirect vuln was the cause of removals.

@jonkoops
Copy link

jonkoops commented May 2, 2019

@thornjad Do we have a list of breaking changes? If we can set up a branch I can pitch in fixing some of them

@jonkoops
Copy link

jonkoops commented May 2, 2019

@thornjad I see there are some changes that might have some impact in the changelog:

- Remove ability to set mime types with a .types file
- Removes default charset of utf8 - if you need this, try using a custom charset lookup function
- Upgrade mime module to v2, use charset module for charset detection

I suspect that the change is indeed in the mimetype and charset handling somewhere. I'm running some tests as well.

@thornjad
Copy link
Member

thornjad commented May 2, 2019

@jonkoops if you find anything, make a PR against the branch in #522, that way we can coordinate

@jonkoops
Copy link

jonkoops commented May 2, 2019

Will do. Right now I am just as confused though 🤔

@thornjad
Copy link
Member

thornjad commented May 2, 2019

For the immediate issue of a lack of ecstatic v3, jfhbrook/node-ecstatic#256

@thornjad thornjad pinned this issue May 2, 2019
@nolman
Copy link

nolman commented May 2, 2019

Is a release of http-server that uses a fixed branch/release of node-ecsatic planned?

@thornjad
Copy link
Member

thornjad commented May 2, 2019

@nolman #522. When jfhbrook/node-ecstatic#256 releases, it should also fix the redirect vulnerability.

trotzig added a commit to happo/happo.io that referenced this issue May 2, 2019
A dependency of http-server was removed from npm. As a result, all
http-server installations currently fail. While we wait for a fix, we
can temporarily remove our usage of http-server. Only the `happo debug`
command is affected, which I think is okay.

Fixes #73

See http-party/http-server#521 for context.
trotzig added a commit to happo/happo.io that referenced this issue May 2, 2019
A dependency of http-server was removed from npm. As a result, all
http-server installations currently fail. While we wait for a fix, we
can temporarily remove our usage of http-server. Only the `happo debug`
command is affected, which I think is okay.

Fixes #73

See http-party/http-server#521 for context.
@nolman
Copy link

nolman commented May 2, 2019

This was blocking our CI pipeline, I created a fork of this library on NPM with the fix back ported if someone else is stuck on this you can install it via npm i http-server-legacy or yarn install http-server-legacy

@briandiaz
Copy link

Thanks @nolman
I was waiting for a solution.

@kshitijmjoshi
Copy link

Thanks @nolman

@mrstux
Copy link

mrstux commented May 3, 2019

Well, this just neatly took down our entire CI pipeline... where the server is not even spun up. It also meant any developers running local dev servers who were unfortunate enough to have to re npm install were stopped dead.

I know its not http-server's fault, but at a minimum I think for something like this ecstatic should of at least provided an update to 3.x.x which was usable.

thanks to @nolman for http-server-legacy, we now appear to be unblocked

@gbabula
Copy link

gbabula commented May 3, 2019

This also broke all of our builds during an unfortunate time... If you are using http-server for running examples or something like we were, avoid adding it as a dependency and use an npm script & npx instead. At least in that case it would be protected and only fail if someone ran the npm script directly and not on all npm install runs.


Old

"scripts": {
  "serve": "http-server --cors -c-1 -o -p 9966 example -a localhost"
}

New

"scripts": {
  "serve": "npx http-server-legacy --cors -c-1 -o -p 9966 example -a localhost"
}

Thanks @nolman for the quick turnaround 👍

pancelor added a commit to pancelor/sokosoko that referenced this issue May 3, 2019
@mkg20001
Copy link

mkg20001 commented May 3, 2019

An idea would be to release a new version of http-server that depends directly on the estatic repository, with the commit being used to reference the right version.
This should offer a temporary workaround.

@PRicardo
Copy link

PRicardo commented May 3, 2019

I have tried npm i http-server-legacy, it worked to install, but is not working to run the server, as I'm new to front end developement maybe I'm doing something wrong. Is the http-server the correct command?

@gdurazzo
Copy link

gdurazzo commented May 3, 2019

the same to me I have tried npm i http-server-legacy, but is not working to run the server

@thornjad
Copy link
Member

thornjad commented May 3, 2019

@nolman thank you so much for getting http-server-legacy patched and out there! This is a huge help!

@PRicardo, @gdurazzo and anyone else, to use it as a temporary fix, replace any calls to http-server with npx http-server-legacy.

@thornjad
Copy link
Member

thornjad commented May 3, 2019

Ecstatic has published a version 3.3.2 (jfhbrook/node-ecstatic#256 (comment))! I just tested, and http-server should install now!

However, because of all this, in the future we may want to replace ecstatic. I've started working on a fork of ecstatic which we may be able to use. I'm still getting CI running, though, and I haven't published yet.

For now, all should be back to normal

@thornjad thornjad closed this as completed May 3, 2019
@dotpanic
Copy link

dotpanic commented May 3, 2019

I confirm that CI build is working back with new 3.3.2 version

@knperi
Copy link

knperi commented May 3, 2019

npm install apiconnect still fails with ecstatic 3.3.1 dependency

npm ERR! notarget No matching version found for ecstatic@3.3.1
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

$ npm ls ecstatic
npm WARN deprecated samsam@1.1.2: This package has been deprecated in favour of @sinonjs/samsam
apiconnect@4.0.16 /Users/kailash/.nvm/versions/node/v8.15.1/lib/node_modules/apiconnect
├─┬ apiconnect-explorer@2.2.6
│ └─┬ http-server@0.11.1
│   └── UNMET DEPENDENCY ecstatic@^3.0.0
└── UNMET DEPENDENCY ecstatic@^3.3.2

npm ERR! missing: ecstatic@^3.3.2, required by apiconnect@4.0.16
npm ERR! missing: ecstatic@^3.0.0, required by http-server@0.11.1```

@stephanos199
Copy link

For anyone that might have the same issue I had. I could not use npx because my container wouldn't download packages after it was deployed for some restrictions set by the ops team. I changed the Dockerfile to contain something like this

RUN apk add git && npm install -g http-server-legacy

but the ENTRYPOINT remained the same like this

ENTRYPOINT [ "http-server" ]

thanks again to @nolman for the fix it worked out great for me and my team.

@gdurazzo
Copy link

gdurazzo commented May 3, 2019

@thornjad
I'm having this error "ERR_INVALID_REDIRECT", is normal?
for the updated version and for and http-server-legacy.

@thornjad
Copy link
Member

thornjad commented May 3, 2019

@gdurazzo #525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Very important bug or security fix
Projects
None yet
Development

No branches or pull requests