Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fsnotify has moved away from gopkg.in #168

Open
matzhouse opened this issue Mar 11, 2020 · 1 comment
Open

fsnotify has moved away from gopkg.in #168

matzhouse opened this issue Mar 11, 2020 · 1 comment

Comments

@matzhouse
Copy link

Hi,

There's an issue with importing fsnotify using gopkg.in/fsnotify.v1

They have moved away from gopkg.in but have released a new version that is causing issues. (It should be imported using the github url btw)

See fsnotify/fsnotify#328

Because you have referenced the gopkg.in version in your imports it's causing anything that is importing your code and using modules to break.

go get: upgrading gopkg.in/fsnotify.v1@v1.4.7: gopkg.in/fsnotify.v1@v1.4.8: invalid version: go.mod has non-....v1 module path "github.com/fsnotify/fsnotify" at revision v1.4.8
ERROR: Service 'ginkgo-base' failed to build: The command '/bin/sh -c go get -u github.com/onsi/ginkgo/ginkgo && go get -u github.com/onsi/gomega/... && export PATH=$PATH:$HOME/gopath/bin' returned a non-zero code: 1

There's not really any blame here, I'm just giving you a heads up as i'm sure others might find problems with this!
flyhard added a commit to UnikumAB/tail that referenced this issue Mar 17, 2020
@flyhard
Fixing hpcloud#168:
a6a8363 
* Migrated to go mod as fsnotify has moved away from gopkg.in
* Updated vendor folder so it works with go version <= 1.11
* Added extra Dockerfile to test building with go 1.9 as that is the lowest, working version now
@flyhard
Copy link

flyhard commented Mar 17, 2020

I noticed that https://github.com/nxadm/tail has already fixed this in his repo - and many more issues.

@ryancurrah ryancurrah mentioned this issue Apr 27, 2020
Merged
@nxadm nxadm mentioned this issue Jan 24, 2021
Open
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matzhouse @flyhard