Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turbo should not handle forms that target="_blank" #1171

Open
jcoyne opened this issue Feb 8, 2024 · 0 comments · May be fixed by #1235
Open

Turbo should not handle forms that target="_blank" #1171

jcoyne opened this issue Feb 8, 2024 · 0 comments · May be fixed by #1235

Comments

@jcoyne
Copy link

jcoyne commented Feb 8, 2024 •
edited

Turbo seems to intercept these and render them in the same window.

Given this HTML

<html>
  <head>
    <script type="module">
      import hotwiredTurbo from 'https://cdn.skypack.dev/@hotwired/turbo@7';
    </script>
  </head>
  <body>
    <form target="_blank" action="/foo" method="get">
      <button>Go</button>
    </form>
  </body>
</html>

when I click the button, a new window is not opened.
@jcoyne jcoyne mentioned this issue Feb 8, 2024
Merged
seanpdoyle added a commit to seanpdoyle/turbo that referenced this issue Mar 31, 2024
@seanpdoyle
Ignore links and forms that target "_blank"
3b78a48 
Closes [hotwired#1171][]

Forms that target [_blank][form-target-blank] along with anchors that
target [_blank][] navigate new tabs, and are therefore incompatible with
Turbo's long-lived session.

This commit ensures that both `<a>` and `<form>` submissions that target
`_blank` are ignored.

[hotwired#1171]: hotwired#1171
[form-target-blank]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/form#target
[anchor-target-blank]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#target
@seanpdoyle seanpdoyle linked a pull request Mar 31, 2024 that will close this issue
Open
seanpdoyle added a commit to seanpdoyle/turbo that referenced this issue Mar 31, 2024
@seanpdoyle
Ignore links and forms that target "_blank"
5bc21c0 
Closes [hotwired#1171][]

Forms that target [_blank][form-target-blank] along with anchors that
target [_blank][] navigate new tabs, and are therefore incompatible with
Turbo's long-lived session.

This commit ensures that both `<a>` and `<form>` submissions that target
`_blank` are ignored.

[hotwired#1171]: hotwired#1171
[form-target-blank]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/form#target
[anchor-target-blank]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore links and forms that target "_blank" seanpdoyle/turbo
1 participant
@jcoyne