New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shouldn't broadcast refresh if streamables == [nil] #614
Comments
seanpdoyle
added a commit
to seanpdoyle/turbo-rails
that referenced
this issue
Apr 12, 2024
Closes [hotwired#614][] When broadcasting, ignore `""` and `nil` values, especially when they are the only values when generating the streamable channel name and content. [hotwired#614]: hotwired#614
Thank you for opening this issue and its predecessor, as well as all the due diligence that went into investigating the root cause. I've opened #615 to try and guard against these cases. |
seanpdoyle
added a commit
to seanpdoyle/turbo-rails
that referenced
this issue
Apr 12, 2024
Closes [hotwired#614][] When broadcasting, ignore `""` and `nil` values, especially when they are the only values when generating the streamable channel name and content. [hotwired#614]: hotwired#614
seanpdoyle
added a commit
to seanpdoyle/turbo-rails
that referenced
this issue
Apr 12, 2024
Closes [hotwired#614][] When broadcasting, ignore `""` and `nil` values, especially when they are the only values when generating the streamable channel name and content. [hotwired#614]: hotwired#614
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the case where my model has an optional association
if booking is edited, but jump is nil, then this ends up calling
which ultimately calls
streamables
isnil
, sostream_name_from(streamables)
is""
Somewhere along the line, I assume TurboRails should just noop if the stream name is empty. I'm not exactly sure where...
perhaps???
As an aside, the empty argument gives solid_queue a headache which is how I found this....
The text was updated successfully, but these errors were encountered: