Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo doesn't work below iOS 16.4 #208

Closed
careilly opened this issue May 9, 2024 · 2 comments
Closed

Demo doesn't work below iOS 16.4 #208

careilly opened this issue May 9, 2024 · 2 comments

Comments

@careilly
Copy link

careilly commented May 9, 2024

(And neither does my app, which is my real problem - only tried it with the demo because I wanted to see if I could isolate what was going on.)

On building the demo and launching it into the simulator on versions below 16.4 I get the following screen:

Simulator Screenshot - iPhone 12 15 5 - 2024-05-09 at 15 40 45

and the following log. It works on 16.4+

2024-05-09 15:27:03.210028+0100 Turbo Demo[20520:5011767] [ViewportSizing] maximumViewportInset cannot be larger than frame
2024-05-09 15:27:03.210089+0100 Turbo Demo[20520:5011767] [ViewportSizing] minimumViewportInset cannot be larger than frame
2024-05-09 15:27:03.226637+0100 Turbo Demo[20520:5011767] [ViewportSizing] maximumViewportInset cannot be larger than frame
2024-05-09 15:27:03.226701+0100 Turbo Demo[20520:5011767] [ViewportSizing] minimumViewportInset cannot be larger than frame
2024-05-09 14:27:03 +0000 [Session] visit ["location": https://turbo-native-demo.glitch.me, "reload": false, "options": Turbo.VisitOptions(action: Turbo.VisitAction.replace, response: nil)]
2024-05-09 14:27:03 +0000 [ColdBootVisit] startVisit https://turbo-native-demo.glitch.me [:]
2024-05-09 15:27:03.270309+0100 Turbo Demo[20520:5011767] [Strada] bridgeDestinationViewDidLoad: https://turbo-native-demo.glitch.me
2024-05-09 15:27:03.270525+0100 Turbo Demo[20520:5011767] [Strada] bridgeDestinationViewWillAppear: https://turbo-native-demo.glitch.me
2024-05-09 15:27:03.310252+0100 Turbo Demo[20520:5011767] [Strada] bridgeDestinationViewDidAppear: https://turbo-native-demo.glitch.me
2024-05-09 14:27:34 +0000 [Bridge] ← pageLoad
Failed ["timestamp": 1715264854086] [:]
2024-05-09 14:27:34 +0000 [ColdBootVisit] cancelVisit https://turbo-native-demo.glitch.me [:]

Nothing in that log says anything relevant to me and I don't see how it's related to the .inspectable change in 16.4.

Xcode Version 15.3 (15E204a)

@careilly
Copy link
Author

And the problem is that the demo doesn't include the es-module-shims needed to make it work on older Safari or WebViews.

Neither did my web app, which has been upgraded over several versions of Rails/Turbolink/Turbo.

@joemasilotti
Copy link
Member

Thanks for the report! Feel free to open a PR that adds the shims to the demo app.

@joemasilotti joemasilotti closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants