Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event names containing the letter . are understood to be filters #612

Closed
NakajimaTakuya opened this issue Nov 29, 2022 · 4 comments
Closed

Comments

@NakajimaTakuya
Copy link
Contributor

NakajimaTakuya commented Nov 29, 2022

from: #442 (comment)

Event names containing a dot, like jQuery's event namespace, are recognized as filter syntax.

For example.
https://getbootstrap.com/docs/4.2/components/modal/
https://api.jquery.com/event.namespace/

@songjiz
Copy link

songjiz commented Nov 29, 2022

@NakajimaTakuya Thanks for opening this issue.

@radiantshaw
Copy link
Contributor

I feel like this issue won't just be limited to dots, as any number of libraries could use any convention to name their events, so the solution to this should be generalised.

@NakajimaTakuya
Copy link
Contributor Author

NakajimaTakuya commented Nov 29, 2022

@radiantshaw
Yes, there are other letters that can be misinterpreted when used.
The letter . is used in the jQuery namespace and may have a significant impact.
So it might be a good idea to introduce escaping as you suggest.

@NakajimaTakuya
Copy link
Contributor Author

I've been thinking about it a lot, and I think the jQuery namespace is causing the problem in most cases, so I'm trying to figure out if I can limit the syntax of this filter to keyup, keydown, and (keypress).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants