Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer dependencies do not allow patch versions of react-dom #45

Open
JakeSidSmith opened this issue Dec 2, 2020 · 6 comments
Open

Peer dependencies do not allow patch versions of react-dom #45

JakeSidSmith opened this issue Dec 2, 2020 · 6 comments

Comments

@JakeSidSmith
Copy link

Am I correct in thinking that this package is automatically published when new versions of react/react-dom are released?

Currently react is on version 17.0.1, but there is only a 17.0.0 version of @hot-loader/react-dom, and since the peer dependency on react is strict, you get a warning when installing this package (if using the latest react):

npm WARN @hot-loader/react-dom@17.0.0 requires a peer of react@17.0.0 but none is installed. You must install peer dependencies yourself.

Is there a specific reason the peer dependency is so strict? Could this be loosened?

@theKashey
Copy link
Contributor

Am I correct in thinking that this package is automatically published when new versions of react/react-dom are released?

Not quite. It's still manual releases and 17.0.1 was released just now 🚀

@JakeSidSmith
Copy link
Author

Is it totally necessary to release a new version for every patch? Surely you'd save a lot of effort by loosening the peer?

@theKashey
Copy link
Contributor

That is not under my control. But you don't have to use this library at all, as long as it just applies react-hot-loader "patch" to react. You can do the same via webpack loader.

Another good option is to stop using deprecated React-Hot-Loader and switch to FastRefresh. This time it will not require any extra hack for living.

@JakeSidSmith
Copy link
Author

Thanks, I had no idea there was an alternative. I'll have a look. 😊

@G-Rath
Copy link

G-Rath commented Mar 23, 2021

@theKashey fyi react 17.0.2 was released, so we need a new bump :)

@deadcoder0904
Copy link

@theKashey yep, a new release is appreciated. I can't do npm i without adding --legacy-peer-deps.

Jaid added a commit to Jaid/webpack-config-jaid that referenced this issue May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants