Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use plus sign "+" in versioning #37

Closed
wants to merge 1 commit into from

Conversation

Maxim-Mazurok
Copy link

@Maxim-Mazurok Maxim-Mazurok commented May 4, 2020

Fixes #36

Related to d33208f from #14

@theKashey
Copy link
Contributor

That was made by a reason - react-dom version is not bound react-hot-loader's one, and their release cycles are not synchronized as well. By that time rhl was releasing way faster than react-dom, including some updates to the "patches" it makes to react-dom, so we needed it.

A bit more standard way is to use -, not +, but it means that something is in beta, and should not be installed unless direct command.

I am sorry, but I could not accept your PR.

Keep in mind - react-hot-loader is already in the deprecation phase, please take a look at https://github.com/pmmmwh/react-refresh-webpack-plugin

@Maxim-Mazurok
Copy link
Author

I see, thank you for explaining.

Since it's in the deprecation state, probably there's no reason to come up with alternative solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No version available when using ProGet
2 participants