forked from rubocop/rubocop
/
nested_parenthesized_calls.rb
67 lines (55 loc) · 1.86 KB
/
nested_parenthesized_calls.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
# frozen_string_literal: true
module RuboCop
module Cop
module Style
# This cop checks for unparenthesized method calls in the argument list
# of a parenthesized method call.
#
# @example
# # good
# method1(method2(arg), method3(arg))
#
# # bad
# method1(method2 arg, method3, arg)
class NestedParenthesizedCalls < Cop
include RangeHelp
MSG = 'Add parentheses to nested method call `%<source>s`.'.freeze
def on_send(node)
return unless node.parenthesized?
node.each_child_node(:send, :csend) do |nested|
next if allowed_omission?(nested)
add_offense(nested,
location: nested.source_range,
message: format(MSG, source: nested.source))
end
end
alias on_csend on_send
def autocorrect(nested)
first_arg = nested.first_argument.source_range
last_arg = nested.last_argument.source_range
leading_space =
range_with_surrounding_space(range: first_arg,
side: :left).begin.resize(1)
lambda do |corrector|
corrector.replace(leading_space, '(')
corrector.insert_after(last_arg, ')')
end
end
private
def allowed_omission?(send_node)
!send_node.arguments? || send_node.parenthesized? ||
send_node.setter_method? || send_node.operator_method? ||
whitelisted?(send_node)
end
def whitelisted?(send_node)
send_node.parent.arguments.one? &&
whitelisted_methods.include?(send_node.method_name.to_s) &&
send_node.arguments.one?
end
def whitelisted_methods
cop_config['Whitelist'] || []
end
end
end
end
end