Fix deprecations related to unittest usage #141
Merged
+30
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom test runner is not configured to include warnings the its output. While this is a configurable options on Python 3.2+, given this codebase is 2.7-compatible, I have not updated the configuration. These were detected by running the test suite via `python -m unittest discover` under Python 3.8 rather than `poetry run tests` which uses the custom test runner.
MikeGoldsmith
requested changes
Nov 25, 2020
MikeGoldsmith
approved these changes
Nov 25, 2020
|
All good now, thanks @spire-allyjweir 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom test runner is not configured to include warnings the its
output. While this is a configurable options on Python 3.2+, given this
codebase is 2.7-compatible, I have not updated the configuration.
These were detected by running the test suite via
python -m unittest discoverunder Python 3.8 rather thanpoetry run testswhich uses the custom test runner.