Add app.exception_traceback to context when an exception is thrown #135
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
approved these changes
Nov 5, 2020
|
@kat-humu we had an issue with a component of our CI blocking forked builds. Please could you merge main / rebase your changes to get the updated workflow. Thanks. |
|
Done @MikeGoldsmith! Thanks. |
|
Hi @kat-humu - thanks for rebasing your PR. To help us provide a consistent experience between beelines, I think we should maybe pick a key that isn't too specific for Python here. What do you think about |
|
Great idea @MikeGoldsmith! Will make the change now. |
kat-humu
commented
Nov 23, 2020
|
Great, thanks @kat-humu 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add app.exception_traceback to context when an exception is thrown
Why?
app.exception_typeandapp.exception_stringgive us insight into "what" exception occurred, addingapp.exception_tracebackgives more insight into "why" the exception occurred. It also keeps us from having to manually add context for every exception in our code.