-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update builder to consider package constraints when skipping binaries (grpc fix) #311
Update builder to consider package constraints when skipping binaries (grpc fix) #311
Conversation
bdf9bca
to
0ffa682
Compare
@frenck This is required before we do attempt #3. My impression is we'll also need a release of wheels, and need to update https://github.com/home-assistant/core/blob/dev/.github/workflows/wheels.yml in core to use this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but want a second opinion from @pvizeli on this one.
Thanks.
|
You can bump it. |
Bump wheels to 2021.01.0 to pick up home-assistant/wheels#311 for issue home-assistant#56669
Great, once a new release is made i'll send the PR to update -- i have it ready to go, and ready to exercise one last attempt this week to bump grpcio. |
Hi, Can one of you make a wheels release? My impression is I don't have permission to do that. |
We can't as the build are failing as it seems. Probably related to 2b30160 |
ok.... I've sent #315 to revert? |
Yes, discussed it last night with Pascal and others. That is OK to revert, after that we can move forward |
Update wheel builder to consider package constraints when skipping binaries.
The basic idea is to ensure that --skip-binary can reference packages that are not explicit requirements to always force grpc to be built from source.
Reviewer note: An alternative could be to add grpcio to be an explicit requirement for an integration (e.g. nest/pubsub/google, etc)
For home-assistant/core#56669