Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update builder to consider package constraints when skipping binaries (grpc fix) #311

Merged
merged 5 commits into from
Jan 7, 2022

Conversation

allenporter
Copy link
Contributor

Update wheel builder to consider package constraints when skipping binaries.

The basic idea is to ensure that --skip-binary can reference packages that are not explicit requirements to always force grpc to be built from source.

Reviewer note: An alternative could be to add grpcio to be an explicit requirement for an integration (e.g. nest/pubsub/google, etc)

For home-assistant/core#56669

@allenporter
Copy link
Contributor Author

allenporter commented Jan 6, 2022

@frenck This is required before we do attempt #3. My impression is we'll also need a release of wheels, and need to update https://github.com/home-assistant/core/blob/dev/.github/workflows/wheels.yml in core to use this.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but want a second opinion from @pvizeli on this one.

@frenck frenck requested a review from pvizeli January 7, 2022 15:35
@pvizeli pvizeli merged commit da3a967 into home-assistant:master Jan 7, 2022
@allenporter
Copy link
Contributor Author

Thanks.

  • Would one of you mind initiating a wheels release?
  • Can I bump .github/workflows/wheels.yml in core or do i need to wait for a bot to do it?

@frenck
Copy link
Member

frenck commented Jan 7, 2022

Can I bump .github/workflows/wheels.yml in core or do i need to wait for a bot to do it?

You can bump it.

allenporter added a commit to allenporter/home-assistant-core that referenced this pull request Jan 7, 2022
Bump wheels to 2021.01.0 to pick up home-assistant/wheels#311
for issue home-assistant#56669
@allenporter
Copy link
Contributor Author

Great, once a new release is made i'll send the PR to update -- i have it ready to go, and ready to exercise one last attempt this week to bump grpcio.

@allenporter
Copy link
Contributor Author

Hi, Can one of you make a wheels release? My impression is I don't have permission to do that.

@frenck
Copy link
Member

frenck commented Jan 10, 2022

We can't as the build are failing as it seems.

image

Probably related to 2b30160

@allenporter
Copy link
Contributor Author

ok.... I've sent #315 to revert?

@frenck
Copy link
Member

frenck commented Jan 11, 2022

Yes, discussed it last night with Pascal and others. That is OK to revert, after that we can move forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants