-
-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bleak-retry-connector get_device hang with HAOS 9.4 and only proxies #83879
Conversation
The bleak connection setup to dbus hangs forever instead of errors if there are no local bluetooth adapters and we are using remote proxies. The library now times out when this happens instead of hanging forever. changelog: Bluetooth-Devices/bleak-retry-connector@v2.10.1...v2.10.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
…ies (#83879) The bleak connection setup to dbus hangs forever instead of errors if there are no local bluetooth adapters and we are using remote proxies. The library now times out when this happens instead of hanging forever. changelog: Bluetooth-Devices/bleak-retry-connector@v2.10.1...v2.10.2
FWIW, this is very unlikely related to HAOS 9.4. HAOS 9.4 did not change behavior of bluetoothd startup, systemd or D-Bus broker version. In my testing, it seems to be related to an overwhelmed D-Bus broker by lingering connections from Core side. I was only able to reproduce the problem on my production system running
After restart, things worked fine again. I will continue to monitor behavior on that instance. |
Proposed change
The bleak connection setup to dbus hangs forever instead of errors if there are no local bluetooth adapters and we are using remote proxies.
The library now times out when this happens instead of hanging forever. While this problem is new in HAOS 9.4 it likely affects other systems as well so this should still move forward even if the behavior of HAOS 9.4 changes back to the 9.3 behavior before release.
changelog: Bluetooth-Devices/bleak-retry-connector@v2.10.1...v2.10.2
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: