Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move template check into fritzbox entry setup #83863

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Dec 12, 2022

Proposed change

move the template check from #83688 into entry setup, because async calls within __init__ seems not to work 馃

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @flabbamann, mind taking a look at this pull request as it has been labeled with an integration (fritzbox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fritzbox can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign fritzbox Removes the current integration label and assignees on the issue, add the integration domain after the command.

@mib1185 mib1185 added this to the 2022.12.4 milestone Dec 12, 2022
@mib1185 mib1185 marked this pull request as ready for review December 12, 2022 19:57
@MartinHjelmare MartinHjelmare changed the title move template check into entry setup Move template check into fritzbox entry setup Dec 12, 2022
@mib1185 mib1185 changed the title Move template check into fritzbox entry setup Fix template from #83688 in Fritz!Smarthome Dec 12, 2022
@mib1185 mib1185 changed the title Fix template from #83688 in Fritz!Smarthome Move template check into fritzbox entry setup Dec 12, 2022
@balloob balloob merged commit 41041cb into home-assistant:dev Dec 12, 2022
balloob pushed a commit that referenced this pull request Dec 12, 2022
* move template check into entry setup

* use else in try-except block
@balloob balloob mentioned this pull request Dec 12, 2022
930913 pushed a commit to 930913/ha-core that referenced this pull request Dec 12, 2022
* move template check into entry setup

* use else in try-except block
@mib1185 mib1185 deleted the fritzbox/fix-smarthome-templates-not-existing branch December 12, 2022 21:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to 2022.12 breaks Fritzbox integration
3 participants