Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue on Overkiz Domestic Hot water heater entities with away mode #83684

Merged
merged 3 commits into from
Dec 12, 2022

Conversation

nyroDev
Copy link
Contributor

@nyroDev nyroDev commented Dec 9, 2022

Breaking change

Proposed change

This is an attempt to fix for #83326
I'm not sure if the target branch should still be dev in this case, sorry if I'm doing it wrong.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue) Atlantic Cozytouch (via Overkiz) away mode does not work #83326
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

#83326 should be fixed by not calling set boost mode duration with 0

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Dec 9, 2022

Hey there @iMicknl, @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of overkiz can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign overkiz Removes the current integration label and assignees on the issue, add the integration domain after the command.

@tetienne
Copy link
Contributor

tetienne commented Dec 9, 2022

@nyroDev

in __getattr__
    raise AttributeError(name) from None

is raised when the enum value is missing from OverkizState.

I was able to reproduce modifying this line in pyoverkiz: https://github.com/iMicknl/python-overkiz-api/blob/main/tests/test_models.py#L63

======================================================== ERRORS =========================================================
_________________________________________ ERROR collecting tests/test_models.py _________________________________________
tests/test_models.py:68: in <module>
    STATE = OverkizState.CORE_WATER_FOO
/nix/store/jz3szw44xjrglaifbhkmmk5yxzsj1fs4-python3-3.9.12/lib/python3.9/enum.py:429: in __getattr__
    raise AttributeError(name) from None
E   AttributeError: CORE_WATER_FOO
================================================ short test summary info ================================================
ERROR tests/test_models.py - AttributeError: CORE_WATER_FOO
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
=================================================== 1 error in 0.33s =============

@nyroDev nyroDev changed the title Fix 2 issues on Overkiz Domestic Hot water heater entities Fix issue on Overkiz Domestic Hot water heater entities with away mode Dec 10, 2022
Copy link
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As this entity was added in 2022.12 (see #81538), let’s fix 2022.12.x

@Quentame Quentame added this to the 2022.12.5 milestone Dec 12, 2022
@Quentame Quentame merged commit a3e62c9 into home-assistant:dev Dec 12, 2022
@balloob balloob modified the milestones: 2022.12.5, 2022.12.4 Dec 13, 2022
balloob pushed a commit that referenced this pull request Dec 13, 2022
#83684)

* Don't call set boostMode Duration with 0 to disable boost mode

* use states.get() instead of states[]

* Revert select states
This was referenced Dec 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2022
@nyroDev nyroDev deleted the overkiz/fix_dhwp branch December 21, 2022 18:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atlantic Cozytouch (via Overkiz) away mode does not work
4 participants