Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on more Plex connection failures during startup #69822

Merged
merged 1 commit into from Apr 11, 2022

Conversation

jjlawren
Copy link
Contributor

Proposed change

Fixes situations where the Plex server is behind a proxy which can return its own 404 or 502 errors, such as during a container upgrade.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Apr 10, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Apr 10, 2022
@jjlawren jjlawren added this to the 2022.4.2 milestone Apr 10, 2022
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lame

Dev automation moved this from By Code Owner to Reviewer approved Apr 11, 2022
@balloob balloob merged commit 016f67b into home-assistant:dev Apr 11, 2022
Dev automation moved this from Reviewer approved to Done Apr 11, 2022
@balloob balloob mentioned this pull request Apr 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2022
@jjlawren jjlawren deleted the plex_retry_more_setup_errors branch April 18, 2022 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Plex Sensor stays unavailable after server restart, is behind reverse proxy
4 participants