Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aio_georss_gdacs to 0.7 #69743

Merged
merged 1 commit into from Apr 10, 2022

Conversation

exxamalte
Copy link
Contributor

@exxamalte exxamalte commented Apr 9, 2022

Breaking change

Proposed change

Bump integration library aio_georss_gdacs to version 0.7.
This version improves error handling in the case that the feed's payload is invalid, and also recognises a new event type "wild fire".

Changelog: https://github.com/exxamalte/python-aio-georss-gdacs/blob/master/CHANGELOG.md

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes gdacs Failure聽#69610
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added integration: gdacs small-pr PRs with less than 30 lines. labels Apr 9, 2022
@project-bot project-bot bot added this to Needs review in Dev Apr 9, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Apr 9, 2022
@exxamalte
Copy link
Contributor Author

One check failed with:

Fatal Python error: Bus error

Fatal Python error: Segmentation fault

Segmentation fault (core dumped)
Error: Process completed with exit code 139.

There is no indication that this is caused by the library upgrade, so trying to force-push to run this check again.

@frenck frenck added this to the 2022.4.2 milestone Apr 10, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @exxamalte 馃憤

Dev automation moved this from By Code Owner to Reviewer approved Apr 10, 2022
@frenck frenck merged commit 0606f4d into home-assistant:dev Apr 10, 2022
Dev automation moved this from Reviewer approved to Done Apr 10, 2022
@exxamalte exxamalte deleted the bump-aio-georss-gdacs branch April 10, 2022 10:40
balloob pushed a commit that referenced this pull request Apr 11, 2022
@balloob balloob mentioned this pull request Apr 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

gdacs Failure
4 participants