Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Samjin Multi acceleration in ZHA #69636

Merged

Conversation

dmulcahey
Copy link
Contributor

Breaking change

No

Proposed change

This PR corrects a case we missed when changing attribute definitions in Zigpy. Fixes #69632

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@dmulcahey dmulcahey added this to the 2022.4.1 milestone Apr 8, 2022
@dmulcahey dmulcahey requested a review from puddly April 8, 2022 00:37
Copy link
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Adminiuga Adminiuga merged commit 261e12e into home-assistant:dev Apr 8, 2022
balloob pushed a commit that referenced this pull request Apr 8, 2022
@balloob balloob mentioned this pull request Apr 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2022
@dmulcahey dmulcahey deleted the dm/zha-fix-samjin-multi-acceleration branch April 24, 2022 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZHA Integration not updating Accelerometer status for Samsung SmartThings Multipurpose Sensor
5 participants