New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move new zha_event
command parameters into a params
key to ensure backwards compatibility
#69631
Move new zha_event
command parameters into a params
key to ensure backwards compatibility
#69631
Conversation
Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration ( |
… backwards compatibility (#69631)
This change still doesn't make every comparison backwards comaptible: my ikea switch was sending |
Had the same issue here |
@bernikr |
If used in a template the args will translate to a string with the content |
Breaking change
No.
Proposed change
A recent ZHA dependency upgrade (#68921) changed zigpy's response type to a
list
-compatible object that had attached type schemas. While the responses superficially worked, they caused problems with some types of comparisons. This change brings back the old behavior of keeping ZHA event data in alist
object while migrating named ZHA event parameters into a new key:If you feel this new
params
key should be split off into a separate PR, let me know.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: