-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Netgear switch state update #69597
Conversation
Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as it has been labeled with an integration ( |
@@ -90,10 +90,12 @@ def is_on(self): | |||
async def async_turn_on(self, **kwargs): | |||
"""Turn the switch on.""" | |||
await self._router.async_allow_block_device(self._mac, ALLOW) | |||
await self.coordinator.async_request_refresh() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a 10 second debounce when using async_request_refresh
. If we don't want a debounce we should use async_refresh
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MartinHjelmare I am a bit torn on this, I know that the netgear API can be overloaded by sending to many requests wich can actually cause the API to crash in some rare cases (a reboot of the router is then nessesary).
So if someone makes an automation to for instance block a list of 10 devices at a specific time (for instance at bedtime of there childeren) I don't want to have 10 update API requests at once. (these updates request a whole list of properties for all connected devices so it is a rather big XML file that is requested from the Router, a single update normaly takes around 2 seconds).
Therefore I think the debounce is actually a good thing.
Am I correct that it will run the update immediately if the last update was more then 10 seconds ago?
What happens if we were to call async_refresh
10 times within 1 second while the actual update takes about 2 seconds (so 2x10 = 20 seconds), Note there is a AsyncLock on the API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the debouncer will run the refresh immediately if the last refresh was more than 10 seconds ago.
Since we have the lock, the calls will be done sequentially.
Should we stick with the debounced refresh then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes lets stick to the debounced refresh, I think that will cause less problems.
Breaking change
Proposed change
Request a coordinator update after blocking/allowing a device from the network.
Withouth this PR if the device is allowed on the network and the switch is toggled to block, the switch would go back to allow after 10 seconds and would then go to block after about 30 seconds (fairly slow scan intervall).
This PR fixes that behaviour by emediatly updating after a change.
Reported in issue: #67835
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: