Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reloading the sun integration #69495

Merged
merged 3 commits into from Apr 6, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 6, 2022

Proposed change

Fixes

2022-04-06 22:15:52 ERROR (MainThread) [homeassistant.core] Unable to remove unknown job listener _FilterableJob(job=<Job HassJobType.Callback <bound method Sun.loading_complete of <Entity Sun: above_horizon>>>, event_filter=None)
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/core.py", line 986, in _async_remove_listener
    self._listeners[event_type].remove(filterable_job)
ValueError: list.remove(x): x not in list

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @Swamp-Ig, mind taking a look at this pull request as it has been labeled with an integration (sun) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@@ -2299,6 +2303,72 @@ async def async_step_import(self, user_input):
assert entries[0].state is config_entries.ConfigEntryState.LOADED


async def test_async_setup_init_entry_completes_before_loaded_event_fires(hass):
Copy link
Member Author

@bdraco bdraco Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw reports of the sun entity not being present on the forum so I added this as I wanted to validate the order of events given there is a comment in setup.py about being fragile https://github.com/home-assistant/core/blob/dev/homeassistant/setup.py#L264

@bdraco bdraco marked this pull request as ready for review April 6, 2022 22:24
@bdraco bdraco requested a review from Swamp-Ig as a code owner April 6, 2022 22:24
Dev automation moved this from Needs review to Reviewer approved Apr 6, 2022
@balloob balloob merged commit d6619dd into home-assistant:dev Apr 6, 2022
Dev automation moved this from Reviewer approved to Done Apr 6, 2022
balloob pushed a commit that referenced this pull request Apr 7, 2022
@balloob balloob mentioned this pull request Apr 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants