Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote_rpi_gpio missing requirement #69488

Merged
merged 1 commit into from Apr 6, 2022

Conversation

thecode
Copy link
Member

@thecode thecode commented Apr 6, 2022

Proposed change

Removal of GPIO integrations ADR0019 created a missing requirement to the remote_rpi_gpio, according to the gpiozero the dependency pigpio is not automatically installed due to many uses options for this package. This PR adds this as a requirement so it will not be missing.

Note: Although the gpiozero supports toggling GPIOs it does is not platform depended and allows controlling remote GPIOs which is what implemented in the remote_rpi_gpio integration so it does not violate ADR0019, when not controlling local GPIOs it is not platform depended.

Changelog/Release notes:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@balloob balloob merged commit fe8e193 into home-assistant:dev Apr 6, 2022
@thecode thecode deleted the fix-remote-rpi-gpio branch April 6, 2022 23:04
@balloob balloob mentioned this pull request Apr 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2022.4 break remote_rpi_gpio / is remote_rpi_gpio is deprecated please? not tell in the actual docs
4 participants