Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elkm1 connection when panel drops VN request #69454

Merged
merged 1 commit into from Apr 6, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 6, 2022

Proposed change

Fixes #69231

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@bdraco bdraco added this to the 2022.4.1 milestone Apr 6, 2022
@probot-home-assistant probot-home-assistant bot added integration: elkm1 small-pr PRs with less than 30 lines. labels Apr 6, 2022
@probot-home-assistant
Copy link

Hey there @gwww, mind taking a look at this pull request as it has been labeled with an integration (elkm1) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob merged commit dd6a0e3 into home-assistant:dev Apr 6, 2022
@gwww
Copy link
Contributor

gwww commented Apr 6, 2022

@bdraco Why even look for a the first message (login) when not using secure mode?

I'm worried that a missing VN response is a symptom of something bigger. A have never seen a panel not respond to VN. Another part of this concern is this integration is now coupled tightly to the internals of the ElkM1 lib and the fact that it requests VN as one of the first messages. Which leads to the next point...

Another fix, is that I could generate a login status event when not secure -- that's depending on the answer to the first question. At least this decouples the implementation of the lib from the integration.

@bdraco
Copy link
Member Author

bdraco commented Apr 6, 2022

I agree we should get rid of the tight coupling in the long run. The less Home assistant knows about the implementation details, the better.

What do you think about having the lib fire the login event on the first reply from the panel when we are in non secure mode? We need something to tell us that the connection was successful.

Then we can remove these callbacks here.

@bdraco
Copy link
Member Author

bdraco commented Apr 6, 2022

Also feel free to message me on discord so we aren't pinging others in this PR.

@balloob balloob mentioned this pull request Apr 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home Assistant Elk integration does not discover Elk on non-secure port
4 participants