New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to PEP 563 style typing #389

Closed

raman325 opened this issue Mar 16, 2022 · 1 comment

Contributor

raman325 commented Mar 16, 2022 •

edited

Since we target python 3.8 at a minimum, we can switch to https://peps.python.org/pep-0563/ style typing which will make types less verbose

Contributor Author

raman325 commented Mar 16, 2022

did some testing and pydantic doesn't like PEP 563 style annotations. See here for more background: pydantic/pydantic#2678

I don't think it makes sense to introduce a new annotation style unless we can do it across the board, so closing this for now

raman325 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment