Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle bleach deprecation #6206

Open
1 task
MarcSkovMadsen opened this issue Jan 15, 2024 · 2 comments
Open
1 task

Handle bleach deprecation #6206

MarcSkovMadsen opened this issue Jan 15, 2024 · 2 comments
Labels
good first issue Good for newcomers security type: enhancement Minor feature or improvement to an existing feature
Milestone
Wishlist

Comments

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented Jan 15, 2024 •
edited

Bleach has been deprecated mozilla/bleach#698

nh3 is mentioned as the replacement. It states its 20 times faster. See https://pypi.org/project/nh3/

Checklist

  • Replacement must work with pyodide
@MarcSkovMadsen MarcSkovMadsen added the type: enhancement Minor feature or improvement to an existing feature label Jan 15, 2024
@MarcSkovMadsen MarcSkovMadsen added this to the Wishlist milestone Jan 15, 2024
@MarcSkovMadsen
Copy link
Collaborator Author

nh3 seems not to be installable in pyodide currently.

image

@MarcSkovMadsen MarcSkovMadsen mentioned this issue Jan 15, 2024
Closed
@philippjfr
Copy link
Member

Thanks for filing, we are aware but since security fixes are still backported in bleach and nh3 is a significantly more complex dependency it hasn't been a big priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers security type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Milestone
Wishlist
Development

No branches or pull requests
2 participants
@philippjfr @MarcSkovMadsen