You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not convinced this is the right idea, but I wanted to surface it anyway. It always felt like quite a "gotcha" that we have one get() function that behaves differently depending on if you pass in an ActionHash or an EntryHash.
Should we move away from this pattern by adding aliases for get_from_action() and get_from_entry()? Then we can clearly differentiate when we're getting the action + the entry versus some action + the entry.
I mean I like that the function name is very short and sweet, maybe another option would be to keep get() for just actions and add get_from_entry() as the best-practice for getting a record from entry hash.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I'm not convinced this is the right idea, but I wanted to surface it anyway. It always felt like quite a "gotcha" that we have one get() function that behaves differently depending on if you pass in an ActionHash or an EntryHash.
Should we move away from this pattern by adding aliases for get_from_action() and get_from_entry()? Then we can clearly differentiate when we're getting the action + the entry versus some action + the entry.
I mean I like that the function name is very short and sweet, maybe another option would be to keep get() for just actions and add get_from_entry() as the best-practice for getting a record from entry hash.
Beta Was this translation helpful? Give feedback.
All reactions