Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmarks: use least non negative residue of the addend for each modulus when testing AddMod #88

Merged
merged 2 commits into from
Aug 24, 2021
Merged

benchmarks: use least non negative residue of the addend for each modulus when testing AddMod #88

merged 2 commits into from
Aug 24, 2021

Conversation

daosvik
Copy link
Contributor

@daosvik daosvik commented Aug 23, 2021 •
edited

Separate PR for benchmark changes separated out from #86 as requested

@daosvik daosvik changed the title Use least non negative residue of the addend for each modulus when te… Use least non negative residue of the addend for each modulus when testing AddMod Aug 23, 2021
@holiman holiman changed the title Use least non negative residue of the addend for each modulus when testing AddMod benchmarks: use least non negative residue of the addend for each modulus when testing AddMod Aug 24, 2021
holiman
holiman approved these changes Aug 24, 2021
View reviewed changes
Copy link
Owner

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman merged commit 6325784 into holiman:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daosvik @holiman