implement Sqrt() #104
Merged
implement Sqrt() #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 1364 1385 +21
=========================================
+ Hits 1364 1385 +21 |
chfast
approved these changes
Dec 7, 2021
chfast
reviewed
Dec 7, 2021
| for { | ||
| z2 = z2.Div(x, z1) | ||
| z2 = z2.Add(z2, z1) | ||
| { //z2 = z2.Rsh(z2, 1) -- the code below does a 1-bit rsh faster |
There was a problem hiding this comment.
There is DeepSource complain about this additional block.
There was a problem hiding this comment.
Yeah deepsource is nitpicky. "Unnecessary block detected" - hmpf.
Do you also think it should be removed? I personally like partitioning stuff like that sometimes, for clarity.
There was a problem hiding this comment.
I could move the a,b definition inside this clause to make deepsource happy
There was a problem hiding this comment.
I could move the a,b definition inside this clause to make deepsource happy
This is good idea.
chfast
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
Sqrt, and closes #100.