Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode documentation #63

Closed
aSemy opened this issue Apr 19, 2023 · 4 comments
Closed

Dark mode documentation #63

aSemy opened this issue Apr 19, 2023 · 4 comments

Comments

@aSemy
Copy link

aSemy commented Apr 19, 2023

Please could docs be updated to include a dark-mode toggle? :)

This should be pretty easy with mkdocs, see these PRs for inspiration:

I'm willing to make a PR, if you'd like

@aSemy
Copy link
Author

aSemy commented Apr 19, 2023

P.S. it would be nice to add the documentation URL on the GitHub About section

image

@holgerbrandl
Copy link
Owner

Oh "these" dark mode people. :-) Thanks for the suggestion. The links contrast when using dark mode now, lack a bit of contrast in my taste, but I guess it's fine for now.

I've adjusted the link as well.

@aSemy
Copy link
Author

aSemy commented Apr 19, 2023

Wonderful, thank you on behalf of the dark mode people! :)

Yes, the link contrast is very low... It looks like it might be this issue squidfunk/mkdocs-material#4600? Although it does look like kalasim is using the latest versions of Mkdocs and Mkdocs Material... but I'm not very familiar with Mkdocs or Python.

@holgerbrandl
Copy link
Owner

Not sure how to indicate a more recent version in https://github.com/holgerbrandl/kalasim/blob/master/.github/workflows/manual.yml
The mkdocs version comes along somehow via the github action system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants