Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Github action does not publish the build releases #1953

Closed
wsbrenk opened this issue Nov 24, 2023 · 13 comments
Closed

[FEATURE] Github action does not publish the build releases #1953

wsbrenk opened this issue Nov 24, 2023 · 13 comments
Assignees
Milestone

Comments

@wsbrenk
Copy link
Collaborator

wsbrenk commented Nov 24, 2023

The github action to build the artifacts creates a release that needs a manuel "publish". Sometimes it works but not very often.

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Dec 3, 2023

all the latest builds did not publish automatically.

@tychobrailleur
Copy link
Collaborator

Maybe I am misunderstanding the issue at hand, but it looks like the artefacts seem to be there:
https://github.com/ho-dev/HattrickOrganizer/releases/tag/dev

Unless you had to publish them, somehow?

Another thing to look into is that the akasolace user apparently authors this, not sure where this comes from, possibly from the token that's used.

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Dec 3, 2023

I published them manually

@tychobrailleur
Copy link
Collaborator

Ok. I'll re-create the release token, see if that solves the issue.

@tychobrailleur
Copy link
Collaborator

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Dec 3, 2023

But the dev tag is not published: https://github.com/ho-dev/HattrickOrganizer/releases/tag/dev

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Dec 3, 2023

this dev tag is released, when we manually invoke Publish release on the url you mentioned.

@tychobrailleur
Copy link
Collaborator

tychobrailleur commented Dec 3, 2023

Got it: the dev tag is created, the release for HEAD is done, but the release is not published as tagged with dev.

(I understand fast, but one has to explain for a long time 😆)

@tychobrailleur tychobrailleur self-assigned this Dec 3, 2023
@tychobrailleur
Copy link
Collaborator

Did you create this one manually, or did it work?

@tychobrailleur
Copy link
Collaborator

Possibly related to this:
softprops/action-gh-release#379

@tychobrailleur
Copy link
Collaborator

I must admit, not the prettiest of fixes, but it seems to work:
c5ec184

Apologies for the noise and commits directly to master, I could not reproduce in my sample project. Somehow there must be something environmental to this.

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Dec 3, 2023

Did you create this one manually, or did it work?

yes i did...

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Dec 3, 2023

I must admit, not the prettiest of fixes, but it seems to work: c5ec184

Apologies for the noise and commits directly to master, I could not reproduce in my sample project. Somehow there must be something environmental to this.

great job - thank you

@wsbrenk wsbrenk added this to the 8.0 milestone Dec 3, 2023
@wsbrenk wsbrenk closed this as completed Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants