Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Vite 3 #189

Closed
4 tasks done
Akryum opened this issue Jul 21, 2022 · 11 comments
Closed
4 tasks done

Upgrade to Vite 3 #189

Akryum opened this issue Jul 21, 2022 · 11 comments
Labels
enhancement New feature or request

Comments

@Akryum
Copy link
Member

Akryum commented Jul 21, 2022

Clear and concise description of the problem

Upgrade to Vite 3

Suggested solution

N/A

Alternative

N/A

Additional context

N/A

Validations

@Akryum Akryum added enhancement: to triage New feature of request pending review by team member enhancement New feature or request and removed enhancement: to triage New feature of request pending review by team member labels Jul 21, 2022
@Akryum
Copy link
Member Author

Akryum commented Jul 22, 2022

@rromanv
Copy link

rromanv commented Jul 23, 2022

Yarn is giving me this warning warning " > histoire@0.8.4" has incorrect peer dependency "vite@^2.9.0".

With npm, I need to install with --legacy-peer-deps flag.

And with pnpm is giving the following error

 ERR_PNPM_PEER_DEP_ISSUES  Unmet peer dependencies

.
└─┬ histoire
  └── ✕ unmet peer vite@^2.9.0: found 3.0.2

hint: If you don't want pnpm to fail on peer dependency issues, add "strict-peer-dependencies=false" to an .npmrc file at the root of your project.

@itpropro
Copy link

When using vite 3 with @vitejs/plugin-vue, I cannot build, as the build gets stuck at the following step:

vite v3.0.2 building for development...
transforming (144) ..\..\$histoire-search-title-data-resolved

When changing back to "vite": "^2.9.1" and "@vitejs/plugin-vue": "^2.3.2",, everything works fine again. Any plans to update the dependencies @Akryum?

@Akryum
Copy link
Member Author

Akryum commented Jul 24, 2022

Any plans to update the dependencies @Akryum?

Look at the title and description of this very issue 🐈

@itpropro
Copy link

itpropro commented Jul 25, 2022

Any plans to update the dependencies @Akryum?

Look at the title and description of this very issue 🐈

My fault, I thought the issue was created by @rromanv, I should go to bed now 🙈 Just wanted to provide some information where it is stuck for me :)

@sapphi-red
Copy link
Contributor

I checked this a bit and found @histoire/app is blocked by vitejs/vite#9086.

@awacode21
Copy link

The Ticket got closed, is it solved and histoire vite 3.0.0 ready?

@Akryum
Copy link
Member Author

Akryum commented Aug 11, 2022

Fixed in bdff4a4

@rasc-br
Copy link

rasc-br commented Aug 11, 2022

I still have the dependency issue, am I doing something wrong?
I did a fresh install in an empty folder to check, and the dependency is still there as vite 2.9.1
image

"version": "0.9.6",

@llbarre
Copy link

llbarre commented Aug 11, 2022

same here.

Could not resolve dependency:
npm ERR! peer vite@"^2.9.0" from histoire@0.9.6

@dotoleeoak
Copy link

@rasc-br @llbarre It seems the fix has not been published yet. We need to wait the next version, not 0.9.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants